Adding optimizer option to linear models

koaning / scikit-lego

Extra blocks for scikit-learn pipelines.

https://koaning.github.io/scikit-lego/

MIT License

1.29k stars 118 forks source link

Adding optimizer option to linear models #529

Closed glevv closed 2 years ago

glevv commented 2 years ago

Fixes #499

glevv commented 2 years ago

So right now the fix is to set y_numeric=True, which will enforce y to be numeric. But still, it's a lot of changes for something that seemed as a small addition

MBrouns commented 2 years ago

One final question on the default tol value but otherwise it looks good!

MBrouns commented 2 years ago

Thanks for the PR!