Closed CarloLepelaars closed 7 months ago
Hey, yes this feature is ready and meant to be reviewed. I'll make sure to add [WIP] if something would be still work in progress
As for the commits there are some commits here that are already merged to scikit-lego from a previous PR, but somehow it still shows when I create a new local branch. Everything up to commit #f06a7af is duplicate. Do you know how we can clean up the commit history?
Otherwise I think we are ready to merge! Fixed the minor nitpicks.
@koaning, shall we go ahead and merge this one to main
?
This PR adds
get_feature_names_out
functionality forEstimatorTransformer
. This is a desirable method forEstimatorTransformer
because its output is used as input for a subsequent estimator.get_feature_names_out
forEstimatorTransformer
.get_feature_names_out
works with aFeatureUnion
component.get_feature_names_out
implementation is necessary and desired for other Meta estimators.@koaning I think it is not necessary to implement
get_feature_names_out
for the other estimators insklego.meta
, because it seems all these estimators are used as the last component in aPipeline
, except forEstimatorTransformer
.EstimatorTransformer
will often be a component somewhere in the middle of aPipeline
and thereforeget_feature_names_out
is desirable. That said I'm happy to work on other implementations ofget_feature_names_out
insklego.meta
if you disagree with this reasoning.Solves Issue #533