search

koaning / scikit-lego

Extra blocks for scikit-learn pipelines.
https://koaning.github.io/scikit-lego/
MIT License
1.28k stars 118 forks source link

Broken Deployment #612

Closed KulikDM closed 10 months ago

KulikDM commented 10 months ago

Hi @koaning, was just running my own github actions which failed. I traced it back to here (ModuleNotFoundError: No module named 'sklego.meta'). I saw that there was a recent release (0.7.1) and downloaded the tarball. When I checked inside it seems like all the folders besides data are missing from the sklego folder. Hope the issue is nothing too serious.

koaning commented 10 months ago

Oh dear. That might have been me. Thanks for reporting it @KulikDM, will have a look right away.

koaning commented 10 months ago

That's very weird, the same command that I've used for 5+ years now no longer includes the submodule. I made another release, to test if I had skipped a command, but same result.

As a fix for now I've decided to yank v0.7.1 and v0.7.2 so that when folks install the most recent it will at least be a version with the meta submodule. In the meantime that means it won't break builds for folks while we figure out what's going on here.

Sorry about this!

koaning commented 10 months ago

OK. That took some manual effort. Again, sorry about that ... but after fixing v0.7.1 and v0.7.2 and v0.7.3 ... we now have something that works.

I checked manually and meta is now in there again. Should be all good, but let me know if it broke for any other reason. Again, sorry about that, and thanks for reporting this one so early!

KulikDM commented 10 months ago

You are a really champ @koaning ! Thanks for addressing this so quickly and hope that you find what's happening with the publish command. All the best!

koaning commented 10 months ago

It wasn't just me, @FBruzzesi was the one who found the fix!

KulikDM commented 10 months ago

Thanks @FBruzzesi !