koaning / scikit-lego

Extra blocks for scikit-learn pipelines.
https://koaning.github.io/scikit-lego/
MIT License
1.28k stars 117 forks source link

`GroupedPredictor` patch #619

Closed FBruzzesi closed 8 months ago

FBruzzesi commented 9 months ago

Description

As discussed in #616, shrinkage was intended for regression problems and even if in some cases it doesn't raise errors, it would yield incorrect results for classification or outlier detection tasks.

This PR:

Fixes #616

Type of change

Checklist:

koaning commented 8 months ago

@FBruzzesi Any concerns about releasing this right away?

FBruzzesi commented 8 months ago

@FBruzzesi Any concerns about releasing this right away?

Not sure if it's better to go 0.7.5 (as in the info admonitions) or to 0.8.0 as it has breaking changes (no more shrinkage for classification).

If you want to wait for the HierarchicalPredictors, I may need a few more days just to open the PR