koaning / scikit-lego

Extra blocks for scikit-learn pipelines.

https://koaning.github.io/scikit-lego/

MIT License

1.28k stars 117 forks source link

Make RegressionOutlier dataframe-agnostic #665

Closed MarcoGorelli closed 6 months ago

MarcoGorelli commented 6 months ago

Description

Fairly simple 👌

Fixes #(issue)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the style guidelines (ruff)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (also to the readme.md)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added tests to check whether the new feature adheres to the sklearn convention
[ ] New and existing unit tests pass locally with my changes

FBruzzesi commented 6 months ago

Grazie Marco, amazing work! Sorry for delegating the checks but I don't have a GPU setup ready 😁