koaning / scikit-lego

Extra blocks for scikit-learn pipelines.

https://koaning.github.io/scikit-lego/

MIT License

1.28k stars 118 forks source link

patch: `.drop(columns=...)` test hotfix #678

Closed FBruzzesi closed 5 months ago

FBruzzesi commented 5 months ago

Description

Fix a test that is failing in CI (--pre flag) since polars does not support the columns keyword in drop method.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines (ruff)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (also to the readme.md)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added tests to check whether the new feature adheres to the sklearn convention
[ ] New and existing unit tests pass locally with my changes

FBruzzesi commented 5 months ago

It's just a test, nothing changes in the source code. However we could do 0.9.1 due to #675 and #676