FBruzzesi commented 5 months ago

Description

Addresses both problems presented in #674, namely:

Fixes #674

Opening as draft since the issue has not been discussed

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[x] My code follows the style guidelines (ruff)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (also to the readme.md)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added tests to check whether the new feature adheres to the sklearn convention
[x] New and existing unit tests pass locally with my changes

FBruzzesi commented 4 months ago

Merging main broke CI?! Confusion to the max! 🤔

koaning commented 4 months ago

This might be related to polars v1.0.0 that came out today. Feels plausible looking at the error messages.