koaning / scikit-lego

Extra blocks for scikit-learn pipelines.

https://koaning.github.io/scikit-lego/

MIT License

1.28k stars 117 forks source link

patch: `strict=False` in polars constructor #684

Closed FBruzzesi closed 4 months ago

FBruzzesi commented 4 months ago

Description

I wonder how this was not failing before, anyway, now all polars constructors in test_pandas_utils use the strict=False flag

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the style guidelines (ruff)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (also to the readme.md)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added tests to check whether the new feature adheres to the sklearn convention
[x] New and existing unit tests pass locally with my changes