search

koaning / whatlies

Toolkit to help understand "what lies" in word embeddings. Also benchmarking!
https://koaning.github.io/whatlies/
Apache License 2.0
469 stars 50 forks source link

Dependency Installation goes Awry #139

Closed koaning closed 4 years ago

koaning commented 4 years ago
image

If I have a new virtualenv with no tensorflow-text then we can still get silly import errors. Need to fix this.

koaning commented 4 years ago

After installing tensorflow-text we get this:

image.

mkaze commented 4 years ago

Ah, yeah right.... I thought you have used conditional imports when you made the dependency PR?! I completely forgot to mention that then (though, I vaguely remember I have mentioned it somewhere?!... I don't know where!). This certainly needs to be fixed.

koaning commented 4 years ago

It's also the transfromers.

image
koaning commented 4 years ago

@mkaze Yeah something went wrong here. I'm curious why the tests passed too. Probably good to iterate on both soonish. I might have time in a few hours to start working on this.

mkaze commented 4 years ago

I'm curious why the tests passed too.

The answer is easy: because no test is run in dependencies workflow; rather, just the package is installed. And that's for a good reason: if the package is not installed in full, the test suit could not be run (otherwise, it would report some failing tests due missing dependecies).

koaning commented 4 years ago

I suppose we could run some one-line import statements as an alternative. That's what we're interested in testing anyway.