search

kobaltcore / renconstruct

A utility script to automatically build Ren'Py applications for multiple platforms.
MIT License
7 stars 2 forks source link

Support log line grouping per build type #3

Closed devorbitus closed 3 years ago

devorbitus commented 3 years ago

Creating this issue for reference as a low-hanging-fruit new feature specifically for GitHub Actions would be really nice while not affecting regular installations

Reference: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#grouping-log-lines

echo "::group::My title"
echo "Inside group"
echo "::endgroup::"

kobaltcore commented 3 years ago

Just to make sure I understand this correctly: This would affect the logging system of renconstruct such that it changes its format to the one you exemplified above, correct? In cases where renconstruct would run in a GitHub action, it would produce output as normal but would supply "grouping text" at specific points?

devorbitus commented 3 years ago

Yes, it could literally be just "around" the different builds as additional logging statements specifically for GH actions. Everything else would be the same.

kobaltcore commented 3 years ago

It appears we can check whether we're running in the Actions environment using the GITHUB_ACTIONS environment variable, which will always exist and be set to true if this is the case.

As such, I can add a check to renconstruct and if it is running as an action, it can output action boundaries where appropriate.

kobaltcore commented 3 years ago

I have added basic support for this.

One problem is that building platforms aside from Android happens in one shot. That is, there is currently no way to split/group output into several distinct groups.

As such, there will only be these groups:

devorbitus commented 3 years ago

Still useful I bet, thanks for this!

devorbitus commented 3 years ago

a8fea725770f29ef226aa4b4882aac1a3b8e0204 makes this issue closed, thanks!