search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.2k stars 61 forks source link

Got an error on new group variants in tailwind plugin #101

Closed ceopaludetto closed 1 year ago

ceopaludetto commented 1 year ago

Describe the bug The implementation of group and peer variants are incorrect, making postcss crash

To Reproduce

  1. Intall @kobalte/tailwindcss
  2. Try to use any group or peer variant
  3. Get this error:
Stack trace Error: Expected a pseudo-class or pseudo-element. at Root._error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:174:16) at Root.error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/selectors/root.js:43:19) at Parser.error (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:740:21) at Parser.expected (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1133:19) at Parser.pseudo (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:895:19) at Parser.parse (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1084:14) at Parser.loop (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:1043:12) at new Parser (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/parser.js:164:10) at Processor._root (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/processor.js:53:18) at Processor._runSync (/Users/carlos/Documents/Projetos/Javascript/solid-material/node_modules/.pnpm/postcss-selector-parser@6.0.11/node_modules/postcss-selector-parser/dist/processor.js:100:21)

Expected behavior Group and peer variants should work

Additional context I think group and peer variants have an unnecessary : in declaration. Should be :merge(.group)[data-${state}] &

https://github.com/fabien-ml/kobalte/blob/17db58a85daa8cc8508df3317d7e8e6fe0944079/packages/tailwindcss/src/index.js#L35

fabien-ml commented 1 year ago

fixed in v0.4.1 of the tailwind plugin