Use native HTML attribute names instead of `isX` or `hasX` to avoid confusion

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.

https://kobalte.dev

MIT License

1.27k stars 71 forks source link

Use native HTML attribute names instead of `isX` or `hasX` to avoid confusion #166

Closed fabien-ml closed 1 year ago

fabien-ml commented 1 year ago

Describe the bug Some components has both isDisabled and disabled props which is a bit confusing. It would be cleaner to expose just one.

Expected behavior Expose only one prop when equivalent exist as HTML attribute (disabled, required, readOnly, etc...).

jcmonnin commented 1 year ago

Similar issue for Checkbox: onCheckedChange vs onChange.

For the Kobalte checkbox, onChange is not reported, so my Checkbox migrated from Hope-UI didn't work before switching to onCheckedChange. It would be better if TypeScript would catch it.

Reporting them on a case-by-case basis as they appear.