search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.27k stars 69 forks source link

Select `options` non reactive #386

Closed jer3m01 closed 5 months ago

jer3m01 commented 6 months ago

Extract from https://discord.com/channels/722131463138705510/1063803756388548709/1228319433013989447

It is in this line: https://github.com/kobaltedev/kobalte/blob/main/packages/core/src/primitives/create-collection/create-collection.ts#L40 The effect does not reexecute when a resource's value changes (from nothing to the resolved data). Replacing it with a render effect makes it work, but I don't know if that is the correct solution. I have made a broken-down reproduction of it here: https://stackblitz.com/edit/solidjs-templates-g7d9h6?file=src%2Fcomponents%2Flistbox%2Flistbox-root.tsx I added some console.logs so when you change the render effect here: https://stackblitz.com/edit/solidjs-templates-g7d9h6?file=src%2Fcomponents%2Fprimitives%2Fcreate-collection%2Fcreate-collection.ts%3AL50 back to a normal effect you can observe where the collection is right and where it does not contain anything anymore.