search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.2k stars 61 forks source link

Use optionTextValue in filtering #436

Closed Brendonovich closed 1 month ago

Brendonovich commented 1 month ago

From the Combobox docs:

optionTextValue: The property name to use as the text value of an option for filtering and keyboard navigation.

Currently optionLabel is used for filtering instead of optionTextValue. This PR changes filterFn to use optionTextValue for filtering.

netlify[bot] commented 1 month ago

Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
Latest commit d57f892209e7a8dc54d70dc6bdb9379dbf56412a
jer3m01 commented 1 month ago

Sweet thanks!