search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.2k stars 61 forks source link

Update Polymorphic to override the "component" prop of Dynamic #437

Closed alfredomariamilano closed 1 month ago

alfredomariamilano commented 1 month ago

It took me a while to find the culprit of why my component wasn't working and it was as simple as my "component" prop overriding the component prop passed to SolidJS' Dynamic component.

Either this, or we should pass the Dynamic component's props as the Polymorphic props in TypeScript.

netlify[bot] commented 1 month ago

Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
Latest commit 9f94211917061a0076ccb94b12a4e73c3343a8ca
jer3m01 commented 1 month ago

Awesome thanks for the catch!