search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.3k stars 75 forks source link

feat: added chip component #507

Open Swappea opened 3 weeks ago

Swappea commented 3 weeks ago

Description

netlify[bot] commented 3 weeks ago

Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
Latest commit 99ba32e66dbbeb5ecbfa14e1670da2ef6fe8c2ab
jer3m01 commented 3 weeks ago

Thanks for the interest and PR!

Chip component overlaps a lot with Badge (PR unmerged but already approved), we might want to add the onClick and closeable feature to it instead.

I'll think over it and get back to you.

Swappea commented 3 weeks ago

Thanks for the interest and PR!

Chip component overlaps a lot with Badge (PR unmerged but already approved), we might want to add the onClick and closeable feature to it instead.

I'll think over it and get back to you.

Originally I thought badge component was supposed to be similar to notification badges we have in our OS. Chip components are normally used as things to filter out, tagging stuff, & many more and also commonly named as Chip. That's why decided to add this component.

I see what you mean though. I will also research further on my side.

Also do let me know if there any other components to which I can contribute which might be in your backlog to avoid duplicate work :)