Open MengLinMaker opened 2 weeks ago
Firstly, is this a bug or feature? - code appears to be written intentionally
When combobox & search (which uses combobox) blurs, the old options are shown temporarily.
options
There are 2 sources of truths for displayed options:
local.options
lastDisplayedOptions
But this leads to janky behaviour as the popover content closes - especially on animation.
Slow down css animation to see the jank
https://github.com/user-attachments/assets/1c9c9753-9889-41df-a048-5da53794d29a
Close without content changing:
https://github.com/user-attachments/assets/255b5a57-1296-47c3-a096-3c214b1acc63
Location of code behaviour combobox-base.tsx:
const displayedOptions = createMemo(() => { if (disclosureState.isOpen()) { if (showAllOptions()) { return local.options!; } return filteredOptions(); } return lastDisplayedOptions(); });
Firstly, is this a bug or feature? - code appears to be written intentionally
Describe the bug
When combobox & search (which uses combobox) blurs, the old
options
are shown temporarily.There are 2 sources of truths for displayed
options
:local.options
provided through propslastDisplayedOptions
used internally to "Prevents the popover contents from updating as the combobox closes"But this leads to janky behaviour as the popover content closes - especially on animation.
To Reproduce
Slow down css animation to see the jank
https://github.com/user-attachments/assets/1c9c9753-9889-41df-a048-5da53794d29a
Expected behavior
Close without content changing:
https://github.com/user-attachments/assets/255b5a57-1296-47c3-a096-3c214b1acc63
Additional context
Location of code behaviour combobox-base.tsx: