search

kobaltedev / kobalte

A UI toolkit for building accessible web apps and design systems with SolidJS.
https://kobalte.dev
MIT License
1.3k stars 75 forks source link

feat: TimeField component #529

Open HBS999 opened 6 days ago

HBS999 commented 6 days ago

This PR adds a new TimeField component.

Closes #317

netlify[bot] commented 6 days ago

Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
Latest commit 50941a92f41f40c7a21eb5d053c65167b20fa1f3
HBS999 commented 5 days ago

~I dont see how the failed tests are related to this PR.~ Looks like a flaky test. It passes now.

HBS999 commented 4 days ago

Hey Jeremy, thanks for the review!

Placeholder doesn't seem to work (W11 FF 132.0.2):

When you increment the hour, it doesn’t start at 9?

jer3m01 commented 4 days ago

When you increment the hour, it doesn’t start at 9?

Yeah it does, I still think it would be good to also make it display the placeholder in gray (and become a value on first interact).