kobaltz / clamby

ClamAV interface to your Ruby on Rails project.
MIT License
132 stars 29 forks source link

Make it possible for the version check to use the clamdscan executable #20

Closed ahukkanen closed 5 years ago

ahukkanen commented 5 years ago

We are integrating this gem to another framework and we would like to do the version check during the application's startup process.

Currently this gem does it with the clamscan executable even when the daemonize configuration option is set to true. The check could also be done using the clamdscan executable: https://linux.die.net/man/1/clamdscan

It is just a minor annoyance as this only happens once in the startup process of the application but would save few seconds of execution time during the startup. Would be nice change from our perspective if it doesn't pose any possible issues in the existing applications using this gem.

I thought I'd ask whether there is any reasoning behind this before suggesting any changes to the behavior. We would like to change this line to:

  new.run scan_executable, '--version'

Would you see any behavioral impacts of this change in the existing applications that are using this?