search

kobaltz / clamby

ClamAV interface to your Ruby on Rails project.
MIT License
132 stars 29 forks source link

Handle system() failing to execute client #28

Closed emilong closed 5 years ago

emilong commented 5 years ago

In production, we've seen $CHILD_STATUS be nil and thus the call to #exitstatus fail. If I'm reading this correctly - https://ruby-doc.org/core-2.2.3/Process/Status.html - this might happen if the underlying exec() (or possibly fork()?) call fails, so this treats it the same as if the client fails.

We could also break this out into a different error class if people find that valuable.

kobaltz commented 5 years ago

Thanks for the pull request @emilong. This has been pushed to version 1.6.2 and is live now.

emilong commented 5 years ago

Thank you, @kobaltz!