search

kobenguyent / codeceptjs-rphelper

4 stars 23 forks source link

Breaking changes #12

Closed kobenguyent closed 4 years ago

kobenguyent commented 4 years ago
pull-assistant[bot] commented 4 years ago
Score: 0.73

Best reviewed: commit by commit

Optimal code review plan (6 warnings)

rewrite reportportal as plugin
> `index.js` 57% changes removed in minor fixes
testing phase
> `index.js` 48% changes removed in minor fixes
fix some errors
> `test/codecept.conf.js` 41% changes removed in add bdd tests > `index.js` 61% changes removed in minor fixes > `package.json` 67% changes removed in try the events
handle events
> `index.js` 60% changes removed in minor fixes
     handle events      add tests      fix tests
add test script
> `package.json` 50% changes removed in add bdd tests
     try the events
fix tests
> `index.js` 51% changes removed in minor fixes
     Update README.md      minor fixes      Create nodejs.yml      fix package script      clean code      add rp token      add bdd tests      add bdd tests      Merge branch 'master' into refactor      ease eslint      update screenshot

Powered by Pull Assistant. Last update e75316f ... ef46069. Read the comment docs.

kobenguyent commented 4 years ago

@DavertMik @AmsterGet

Sometimes, when sending logs, I got this error. The not found item there is the created TestItem

thanhnguyen@MacBook-Pro test % npx codeceptjs run rp_plugin_test.js --grep @fail
    Emitted | global.before ([object Object])
    11em5cvdlqk6utsnkr: The launchId is started.
CodeceptJS v2.5.0
Using test root "/Users/thanhnguyen/Desktop/codeceptjs-rphelper/test"

RP Plugin tests --
(node:17630) UnhandledPromiseRejectionWarning: Error: Item "11em5cvdlqk6utsoaz" not found
    at RPClient.sendLogWithFile (/Users/thanhnguyen/Desktop/codeceptjs-rphelper/node_modules/reportportal-client/lib/report-portal-client.js:545:53)
    at RPClient.sendLog (/Users/thanhnguyen/Desktop/codeceptjs-rphelper/node_modules/reportportal-client/lib/report-portal-client.js:489:25)
    at /Users/thanhnguyen/Desktop/codeceptjs-rphelper/index.js:165:24
(node:17630) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:17630) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:17630) UnhandledPromiseRejectionWarning: Error: Item "11em5cvdlqk6utsoaz" not found
    at RPClient.sendLogWithFile (/Users/thanhnguyen/Desktop/codeceptjs-rphelper/node_modules/reportportal-client/lib/report-portal-client.js:545:53)
    at RPClient.sendLog (/Users/thanhnguyen/Desktop/codeceptjs-rphelper/node_modules/reportportal-client/lib/report-portal-client.js:489:25)
    at /Users/thanhnguyen/Desktop/codeceptjs-rphelper/index.js:184:24
(node:17630) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
  ✖ Send failed results to RP @fail in 1094ms

-- FAILURES:

  1) RP Plugin tests
       Send failed results to RP @fail:

      expected web application to include "abcdef"
      + expected - actual

      -..
      -We’re updating our Terms of Service. Get to know our new Terms before they take effect on March 31, 2020.ReviewGot it
      -About Store
      -Gmail
      -Images
      -Sign in
      - 
      -Google offered in: Deutsch
      -PrivacyTermsSettings
      -AdvertisingBusinessHow Search works
      +abcdef

  Scenario Steps:

  - I.see("abcdef") at Test.<anonymous> (rp_plugin_test.js:10:7)
  - I.amOnPage("/") at Test.<anonymous> (rp_plugin_test.js:9:7)

  Run with --verbose flag to see NodeJS stacktrace

  FAIL  | 0 passed, 1 failed   // 1s

Maybe you guys know more about it