kobigurk / phase2-bn254

71 stars 234 forks source link

Change multiplicative generator of bn254 to 5 instead of 7 #18

Open jbaylina opened 4 years ago

jbaylina commented 4 years ago

In the field Fr of the curve bn254 the lowest generator is 5 instead of 7.

This is the standard used in other libraries.

See:

This PR breaks backwards compatibility, but I believe it's important to fix it ASAP so we use 5 for the new circuits.

ytrezq commented 2 months ago

@jbaylina : beginner question : why is it important for the value to be the same as other libraries ?