Quick fix for minify script - Githubissues

kobiton / docs

The content for Kobiton Docs.

https://docs.kobiton.com

3 stars 1 forks source link

Quick fix for minify script #103

Closed internetisaiah closed 1 year ago

internetisaiah commented 1 year ago

Summary

Currently a new site.css will be created every time minify-css.sh is run - even if there were no changes to the .css files. I've added a check to ensure site.css is only created if there are changes from the original.
merge-css.sh didn't need to be in a separate file and it was causing slight issues with the checksum, so it's been removed.
Since minify-css.sh was added to yarn build (here: https://github.com/kobiton/docs/pull/101), the explicit call in the workflows has been removed so it's not being called twice.

Related PRs, issues, or features (optional)

N/A

Metadata

[ ] Adds new file(s)
[x] Edits existing file(s)
[x] Removes file(s)

PR contributor checklist

[x] My PR follows the Kobiton Docs contributor guidelines, meaning:
- My content contains correct spelling and grammar.
- My files are named and structured correctly.
- My style and voice follows the Microsoft Style Guide.
- I added all new pages to their section's nav.adoc file.
- I removed all localizations (like en-us) from my URLs.

nhanvvo-kobiton commented 1 year ago

LGTM! Changes are shorter but better. Cool 👍