kobiton / docs

The content for Kobiton Docs.
https://docs.kobiton.com
3 stars 1 forks source link

Adding AsciiDoc tabs extention #132

Closed internetisaiah closed 1 year ago

internetisaiah commented 1 year ago

Summary

Adding AsciiDoc tabs extention. The styling of the tabs need to be modified before this PR is merged (even if the code itself is correct).

Next steps

  1. Confirm project dependencies were correctly installed, source files are in the correct location, tabbing works as expected.
  2. Figure out minimum viable product for the tabbing design and implement. Currently the entire tab box doesn't have enough boarder around it and it's pressed up on the text above (text below is fine).

Screen Shot 2023-07-26 at 17 34 07 PM

Related PRs, issues, or features (optional)

Metadata

PR contributor checklist

internetisaiah commented 1 year ago

Hey @nhanvvo-kobiton and @huyvankobiton,

The design is currently being worked on, but I want to get the basic functionality added to main beforehand. Could one of you look at my changes (specifically the added libraries and handlebar file edits) to ensure there's no major issues that will break the site?

Thanks in advance!

nhanvvo-kobiton commented 1 year ago

From a deployment perspective, these changes should be good, and I have also tested them locally.