Webhook Integration Section Added

kobiton / docs

The content for Kobiton Docs.

https://docs.kobiton.com

3 stars 1 forks source link

Webhook Integration Section Added #204

Closed Hikkigaya closed 6 months ago

Hikkigaya commented 7 months ago

Summary

Added the entire Webhook Integration section in Integrations

Related PRs, issues, or features (optional)

Added content, images, tables, and notes.
Reduced the size of the images.
Adding internal linking to the main integration page as well.

Metadata

[x ] Adds new file(s)
[x ] Edits existing file(s)
[ ] Removes file(s)

PR contributor checklist

[ ] My PR follows the Kobiton Docs contributor guidelines, meaning:
- My content contains correct spelling and grammar.
- My directories and files are named and structured correctly.
- My style and voice follows the Microsoft Style Guide.
- I added all new pages to their section's nav.adoc file.
- I removed all localizations (like en-us) from my URLs.

Hikkigaya commented 6 months ago

Nope, adding the attribute file did not work.

I will just add the two CSS file in .gitignore as well. You were right, the changes were due to working on a Windows machine in which git converts the LF line endings to CRLF.

tungmhoang commented 6 months ago

@Hikkigaya One more thing, the screenshots in this page is taken before our latest design change. Could you use your Kobiton account, follow the webhook guides and take the update screenshots for all images in this doc, making sure that no image is more than 100KB in size? You just need to take the screenshot, no need to do the highlighting.

Hikkigaya commented 6 months ago

@tungmhoang Sure, I will get it done.

Hikkigaya commented 6 months ago

@tungmhoang The images have been updated.

tungmhoang commented 6 months ago

@erincbailey this update is available at http://10.2.7.208/integrations/webhooks/create-and-manage-webhooks. You can start your review.

tungmhoang commented 6 months ago

Looks good. Have a few comments to change. Also - I don't love only having one page in a section. Should we just open this content when you click Webhooks or do you think we should break it into at least two pages?

@Hikkigaya I will push a commit to address this (show the content in Create and manage webhooks right away when opening Webhooks)

tungmhoang commented 6 months ago

@erincbailey please review one more time using this link: http://10.2.7.208/integrations/create-and-manage-webhooks