search

koblas / impalathing

A golang driver for impala via thrift
Other
28 stars 21 forks source link

go get throws error #4

Closed ravisankarv closed 8 years ago

ravisankarv commented 8 years ago

I am getting this error when trying to download the code.

Command tried: go get github.com/koblas/impalathing Error: github.com/koblas/impalathing/services/cli_service src/github.com/koblas/impalathing/services/cli_service/ttypes.go:2157: cannot use byte(*p.Value) (type byte) as type int8 in argument to oprot.WriteByte

koblas commented 8 years ago

Given that generated code, there may be a difference in go thrift implementations.

It also appears that different protocols might implement WriteByte(byte) and WriteByte(int8) -- from reading https://github.com/apache/thrift/search?l=go&p=1&q=WriteByte&utf8=%E2%9C%93

Do you have any more details about the thrift connection your creating?

ravisankarv commented 8 years ago

Thanks for your quick response.

I am currently not using thrift. Do I need thrift to run the code?

db7 commented 8 years ago

Same issue here. Would be glad to learn about a workaround.

koblas commented 8 years ago

This should now be fixed in the following commit which updated to the current thrift libraries.

https://github.com/koblas/impalathing/commit/3cc75c2fe69f7066da4b4487af9a069b059d07cf