fix: French VAT checksum failing for leading zero

koblas / stdnum-js

A JavaScript library to provide functions to handle, parse and validate standard numbers.

MIT License

38 stars 26 forks source link

fix: French VAT checksum failing for leading zero #118

Closed RamonBalthazar closed 2 months ago

RamonBalthazar commented 2 months ago

This is a valid French VAT number: 04813837531. The checksum bit is: 04. The sum is correctly being calculated as 4, but validation fails when comparing "4" with "04".

As a solution we compare numbers instead of strings.

RamonBalthazar commented 2 months ago

@koblas Added test cases :)