search

koblas / stdnum-js

A JavaScript library to provide functions to handle, parse and validate standard numbers.
MIT License
39 stars 26 forks source link

fix(nl): do not pad identifiers to a length of 9 in #clean #19

Closed mikeryancodes closed 2 years ago

mikeryancodes commented 2 years ago

For #17

commit-lint[bot] commented 2 years ago

Bug Fixes

Contributors

mikeryancodes

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
koblas commented 2 years ago

Was re-reading https://nl.wikipedia.org/wiki/Burgerservicenummer it make the statement that the BSN can be 8 or 9 digits. It should be padded to 9 digits for checksum purposes.

I agree that 1 is not valid, but can you update this to handle the 8 or 9 case correctly.