search

koblas / stdnum-js

A JavaScript library to provide functions to handle, parse and validate standard numbers.
MIT License
39 stars 26 forks source link

fix(es): spanish cif checksum fixed #36

Closed wojciechkumon closed 1 year ago

commit-lint[bot] commented 1 year ago

Bug Fixes

Contributors

wojciechkumon

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
wojciechkumon commented 1 year ago

@koblas I found that ES CIF implementation doesn't work with all correct values, could merge that fix, please (there was NaN returned from luhnChecksumDigit() instead of zero and !strings.isdigits(check) blocked letter check digits)?