kobolabs / Kobo-Reader

http://www.koboereader.com/
598 stars 126 forks source link

Runs fsck agressively on sdcard #13

Closed vpelletier closed 9 years ago

vpelletier commented 11 years ago

How to reproduce:

Result: All ebooks from the sdcard (supposedly all with corrupted short names) are renamed, and cannot be read without fixing the SD card content from another device.

What is expected: On FS corruption, kobo should just warn that there is a problem with the sd card and refuse to modify it further (remount read-only). Optionally, kobo should expose more SD card controls: format, eject (=umount), and display when it detects an inserted sdcard (otherwise it's quite difficult to tell what's going on when ebooks just disappear).

[edit] This was noticed on a new koboglo, freshly set up: 2.2.1 (r44772, 09/11/12) [/edit]

gtalusan commented 11 years ago

Hi Vincent

If you upgrade to the latest firmware for your Kobo Touch/Glo/Mini then fsck is already run on the SD card.

On 2012-11-30, at 1:05 AM, Vincent Pelletier notifications@github.com wrote:

How to reproduce:

get an sdcard (vfat-formated) put files with broken short names (for some reason, this happens with asus T700F on latest firmware) put sdcard in kobo get kobo to notice the corruption (I could not reliably reproduce this, happened once when changing margins while having an ebook opened, another time just when changing page) Result: All ebooks from the sdcard (supposedly all with corrupted short names) are renamed, and cannot be read without fixing the SD card content from another device.

What is expected: On FS corruption, kobo should just warn that there is a problem with the sd card and refuse to modify it further (remount read-only). Optionally, kobo should expose more SD card controls: format, eject (=umount), and display when it detects an inserted sdcard (otherwise it's quite difficult to tell what's going on when ebooks just disappear).

\ Reply to this email directly or view it on GitHub.

vpelletier commented 11 years ago

It is run, yes, and this is an issue in my opinion. I would prefer it to:

In the same feature vein:

Just for the record, after getting access to a computer to copy files to a fresh mkfs'ed sdcard, the card works perfectly in the kobo, several books, sync and dictionaries install later. I am very happy of my kobo glo now that I overcame the two issues I reported on this tracker.