search

kobolabs / Kobo-Reader

http://www.koboereader.com/
603 stars 126 forks source link

Update source for Glo, Mini and newer Touch #23

Closed giorgio130 closed 9 years ago

giorgio130 commented 11 years ago

Hi, I've seen that the 2.8.1 release introduces a bug in the touch screen kernel driver. This means the source has to have been modified; but no newer version was uploaded. Please upload a recent version of the source.

gtalusan commented 11 years ago

How do you know it's in the kernel driver?

giorgio130 commented 11 years ago

Thank you for your reply. Are you saying it has not been changed? The thing is right here:

[root@(none) ~]# evtest /dev/input/event1
Input driver version is 1.0.0
Input device ID: bus 0x18 vendor 0x0 product 0x0 version 0x0
Input device name: "zForce-ir-touch"
Supported events:
  Event type 0 (Sync)
  Event type 1 (Key)
    Event code 258 (Btn2)
    Event code 330 (Touch)
  Event type 3 (Absolute)
    Event code 0 (X)
      Value    653
      Min        0
      Max     1200
    Event code 1 (Y)
      Value    861
      Min        0
      Max     1600
    Event code 16 (Hat0X)
      Value      0
      Min        0
      Max     1200
    Event code 17 (Hat0Y)
      Value      0
      Min        0
      Max     1600
    Event code 24 (Pressure)
      Value      0
      Min        0
      Max     2048
Testing ... (interrupt to exit)
Event: time 1376075594.444673 ------- Report Sync ------ x: 904 y: 48 p: 100 ------------
Event: time 1376075594.570110 ------- Report Sync ------ x: 904 y: 49 p: 101 ------------
Event: time 1376075594.599033 ------- Report Sync ------ x: 904 y: 50 p: 100 ------------
Event: time 1376075594.647234 ------- Report Sync ------ x: 903 y: 50 p: 101 ------------
Event: time 1376075594.859444 ------- Report Sync ------ x: 903 y: 49 p: 100 ------------
Event: time 1376075594.869032 ------- Report Sync ------ x: 905 y: 39 p: 101 ------------
Event: time 1376075594.878572 ------- Report Sync ------ x: 39 y: 905 p: 0 ------------

With 2.8.1, last event has x and y values swapped. If I'm right, there's nothing else controlling touchscreen output besides the kernel driver. Consider this a bug report if you wish, but I think I'm right about the changes in code.

gtalusan commented 11 years ago

The kernel hasn't changed. In the Kobo userspace code, when p=0 we recycle the previous point because the last point has historically been garbage.

On Fri, Aug 9, 2013 at 3:16 PM, giorgio130 notifications@github.com wrote:

Thank you for your reply. Are you saying it has not been changed? The thing is right here:

[root@(none) ~]# evtest /dev/input/event1 Input driver version is 1.0.0 Input device ID: bus 0x18 vendor 0x0 product 0x0 version 0x0 Input device name: "zForce-ir-touch" Supported events: Event type 0 (Sync) Event type 1 (Key) Event code 258 (Btn2) Event code 330 (Touch) Event type 3 (Absolute) Event code 0 (X) Value 653 Min 0 Max 1200 Event code 1 (Y) Value 861 Min 0 Max 1600 Event code 16 (Hat0X) Value 0 Min 0 Max 1200 Event code 17 (Hat0Y) Value 0 Min 0 Max 1600 Event code 24 (Pressure) Value 0 Min 0 Max 2048 Testing ... (interrupt to exit) Event: time 1376075594.444673 ------- Report Sync ------ x: 904 y: 48 p: 100 ------------ Event: time 1376075594.570110 ------- Report Sync ------ x: 904 y: 49 p: 101 ------------ Event: time 1376075594.599033 ------- Report Sync ------ x: 904 y: 50 p: 100 ------------ Event: time 1376075594.647234 ------- Report Sync ------ x: 903 y: 50 p: 101 ------------ Event: time 1376075594.859444 ------- Report Sync ------ x: 903 y: 49 p: 100 ------------ Event: time 1376075594.869032 ------- Report Sync ------ x: 905 y: 39 p: 101 ------------ Event: time 1376075594.878572 ------- Report Sync ------ x: 39 y: 905 p: 0 ------------

With 2.8.1, last event has x and y values swapped. If I'm right, there's nothing else controlling touchscreen output besides the kernel driver. Consider this a bug report if you wish, but I think I'm right about the changes in code.

— Reply to this email directly or view it on GitHubhttps://github.com/kobolabs/Kobo-Reader/issues/23#issuecomment-22417336 .

giorgio130 commented 11 years ago

I see, thanks for the clarification. It's still a bug though (x and y swapped), and it's not happening in 2.6.1. Any chance this will be fixed in the next release?