Upgrade active effects applied to non-stored fields can cause value to be `undefined`

koboldpress / black-flag

The official implementation of the Black Flag Roleplaying system within Foundry Virtual Tabletop.

https://www.talesofthevaliant.com

MIT License

4 stars 0 forks source link

Upgrade active effects applied to non-stored fields can cause value to be `undefined` #803

Open arbron opened 3 weeks ago

arbron commented 3 weeks ago

If an active effect is targeting a field that is created during prepareBaseData and the active effect doesn't change the value (e.g. current value is 20, and effect is set to UPGRADE 19), then the resulting value will be undefined. This appears to be a core bug rather than a system bug, but something should be done to see if it can be mitigated on the system end.

arbron commented 3 weeks ago

Related to this core bug: https://github.com/foundryvtt/foundryvtt/issues/11527