search

kobolog / gorb

IPVS on steroids – REST API, heartbeats, service discovery and more
GNU Lesser General Public License v3.0
809 stars 83 forks source link

Register the REST service provided by Gorb isself to Consul. #22

Closed monaka closed 8 years ago

monaka commented 8 years ago

It makes finding the location of load balancer easier. Just by dig gorb.service.counsl @localhost Also it will make fail over easier with using Consul's event functions.

codecov-io commented 8 years ago

Current coverage is 98.16%

Merging #22 into master will not affect coverage as of 2a46c59

@@            master     #22   diff @@
======================================
  Files           13      13       
  Stmts          218     218       
  Branches        34      34       
  Methods          0       0       
======================================
  Hit            214     214       
  Partial          1       1       
  Missed           3       3

Review entire Coverage Diff as of 2a46c59

Powered by Codecov. Updated on successful CI builds.

kobolog commented 8 years ago

Hey there, thanks for the PR. I've left some minor comments.

monaka commented 8 years ago

Ok. I executed go fmt to files that I modified.

kobolog commented 8 years ago

Thanks!