kobolog / gorb

IPVS on steroids – REST API, heartbeats, service discovery and more

GNU Lesser General Public License v3.0

809 stars 83 forks source link

Remove interface addresses(VIPs) when remove services if it were adde… #36

Closed albamc closed 7 years ago

albamc commented 7 years ago

35 PR is merged so we can add VIP(s) to IPVS host interfaces.

But If we remove services, gorb doesn't remove these VIP(s) from interfaces and it'll be remained. So, I add a boolean value to ServiceOptions to determine interface address is add by gorb. And when removing services, remove interface VIP(s) if it were added by gorb.

Signed-off-by: albam.c albam.c@navercorp.com

codecov-io commented 7 years ago

Current coverage is 96.93% (diff: 100%)

Merging #36 into master will not change coverage

@@             master        #36   diff @@
==========================================
  Files            13         13          
  Lines           196        196          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            190        190          
  Misses            4          4          
  Partials          2          2

Powered by Codecov. Last update 80d91f6...23a5534

kobolog commented 7 years ago

Great, thanks for this PR, @albamc!