albamc commented 7 years ago

What I did

Currently, gorb stores L4 data only in memory, so all data is initialized when gorb is restarted. This PR saves the service / backend information generated by gorb to external kvstore (ex. Consul, etcd, zookeeper, boltdb) by using libkv and periodically reads this data and synchronizes it with gorb so that L4 data is retained even if gorb is restarted. I think that merge this PR can solve the following issues.

33 #30

How I did

Use libkv to periodically read the data in the external kvstore. - If service / backend is already in gorb, skip or remove it if key value is different and add it. - Add service / backend if it is not in gorb.

How to test it

# execute gorb with options (assume use consul and it's address is 10.114.177.139:8500)
albamc@albamc-laptop:~/dev/github/albamc/gorb$ sudo ./gorb -f -i wlp1s0 -store consul://10.114.177.139:8500 -store-sync-time 3
INFO[0000] starting GORB Daemon v0.2                    
INFO[0000] initializing IPVS context                    
INFO[0000] Registered the REST service to Consul.       
ERRO[0000] error while get services: Key not found in store 
INFO[0000] setting up HTTP server on :4672              
ERRO[0003] error while get services: Key not found in store 
ERRO[0006] error while get services: Key not found in store 
# create service
  - If you use the gorb api, it also updates the data in kvstore.
  - Or edit kvstore directly
...
# restart gorb (cleanup IPVS before start)
albamc@albamc-laptop:~/dev/github/albamc/gorb$ sudo ipvsadm -C
albamc@albamc-laptop:~/dev/github/albamc/gorb$ sudo ./gorb -f -i wlp1s0 -store consul://10.114.177.139:8500 -store-sync-time 3
INFO[0000] starting GORB Daemon v0.2                    
INFO[0000] initializing IPVS context                    
INFO[0000] Registered the REST service to Consul.       
INFO[0000] creating virtual service [11.0.0.2-80-TCP] on 11.0.0.2:80 
INFO[0000] creating backend [11.0.0.5-80-TCP] on 11.0.0.5:80 for virtual service [11.0.0.2-80-TCP] 
INFO[0000] starting pulse for [11.0.0.2-80-TCP/11.0.0.5-80-TCP] 
INFO[0000] creating backend [11.0.0.3-80-TCP] on 11.0.0.3:80 for virtual service [11.0.0.2-80-TCP] 
INFO[0000] starting pulse for [11.0.0.2-80-TCP/11.0.0.3-80-TCP] 
INFO[0000] creating backend [11.0.0.4-80-TCP] on 11.0.0.4:80 for virtual service [11.0.0.2-80-TCP] 
INFO[0000] starting pulse for [11.0.0.2-80-TCP/11.0.0.4-80-TCP] 
INFO[0000] setting up HTTP server on :4672              
# check IPVS data is restored
albamc@albamc-laptop:~/dev/github/albamc/gorb$ sudo ipvsadm
IP Virtual Server version 1.2.1 (size=4096)
Prot LocalAddress:Port Scheduler Flags
  -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
TCP  11.0.0.2:http rr
  -> 11.0.0.3:http                Tunnel  100    0          0         
  -> 11.0.0.4:http                Tunnel  100    0          0         
  -> 11.0.0.5:http                Tunnel  100    0          0

What to do

use events
- The current logic is inefficient because it reads all the data and synchronizes it with the gorb. Kvstore has a function to notify the event when data is changed, so it would be efficient to update the changed part by receiving the event. I did not process this part because I did not know this PR would be accepted.
separate locks
- The current gorb context uses the lock declared in the context, but it can be better to subdivide the lock for the service or backend.

Added Options

albamc@albamc-laptop:~/dev/github/albamc/gorb$ ./gorb --help
Usage of ./gorb:
...
  -store string
        store url for sync data
  -store-backend-path string
        store backend path (default "backends")
  -store-service-path string
        store service path (default "services")
  -store-sync-time int
        sync-time for store (default 60)
...

Happy new year~

codecov-io commented 7 years ago

Current coverage is 96.93% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files            13         13          
  Lines           196        196          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            190        190          
  Misses            4          4          
  Partials          2          2

Powered by Codecov. Last update 290a2a8...a72ac64