kobolog / gorb

IPVS on steroids – REST API, heartbeats, service discovery and more

GNU Lesser General Public License v3.0

809 stars 83 forks source link

Prometheus exporter #44

Closed diogogmt closed 7 years ago

diogogmt commented 7 years ago

This is a work in progress implementation of a prometheus exporter on gorb.

I'm picking up where this previous PR left off with some adjustments.

There still some work to be done in regards to defining and collecting the exposed metrics and I'll be updating the PR in the coming week.

If anybody has any suggestions/comments please feel free to ping me.

codecov-io commented 7 years ago

Codecov Report

Merging #44 into master will decrease coverage by -65.65%. The diff coverage is 56.6%.

@@             Coverage Diff             @@
##           master      #44       +/-   ##
===========================================
- Coverage   96.93%   31.29%   -65.65%     
===========================================
  Files          13       18        +5     
  Lines         196      767      +571     
===========================================
+ Hits          190      240       +50     
- Misses          4      518      +514     
- Partials        2        9        +7

Impacted Files	Coverage Δ
core/prometheus_exporter.go	`56.6% <56.6%> (ø)`
core/store.go	`3.64% <ø> (ø)`
core/runtime.go	`0% <ø> (ø)`
core/options.go	`0% <ø> (ø)`
core/context.go	`5.39% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b169c92...fa44941. Read the comment docs.

diogogmt commented 7 years ago

@kobolog I still want to do a final review of the metric names+labels being exported and refactor a bit the code and add some tests. However, I would say the bulk is pretty much done.

If you could take a look and let me know your thoughts I think we could land this PR by the end of this week.

kobolog commented 7 years ago

Will take a look tomorrow, thanks a lot for working on it!

On Sun, Feb 5, 2017 at 21:45 Diogo Monteiro notifications@github.com wrote:

@kobolog https://github.com/kobolog I still want to do a final review of the metric names+labels being exported and refactor a bit the code and add some tests. However, I would say the bulk is pretty much done.

If you could take a look and let me know your thoughts I think we could land this PR by the end of this week.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/kobolog/gorb/pull/44#issuecomment-277574914, or mute the thread https://github.com/notifications/unsubscribe-auth/AATdklrYVMACd-kGvqsHcqsrWJMQjDSAks5rZolWgaJpZM4LxA29 .

crisidev commented 7 years ago

Thanks for taking over my old PR, this is amazing!

diogogmt commented 7 years ago

When I open the diff all the vendored files are not loaded and left at the bottom of the page. Is it hogging your memory when opening the diff?

kobolog commented 7 years ago

Yeah, for some reason the first time I opened this PR all vendored deps got loaded so I had to browse thru a million lines of code =) Not the case anymore, maybe was some kind of Github bug.

kobolog commented 7 years ago

I'm gonna land it since the outlined functionality of the PR is done. Maybe we should sync up over email w.r.t IPVS-related setup & testing.