Closed sebbonnet closed 6 years ago
Merging #48 into master will increase coverage by
6.01%
. The diff coverage is70%
.
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 33.39% 39.41% +6.01%
==========================================
Files 18 18
Lines 1018 1030 +12
==========================================
+ Hits 340 406 +66
+ Misses 656 594 -62
- Partials 22 30 +8
Impacted Files | Coverage Δ | |
---|---|---|
pulse/status.go | 54.54% <0%> (-34.35%) |
:arrow_down: |
pulse/pulse.go | 96.87% <100%> (+0.1%) |
:arrow_up: |
core/runtime.go | 60.71% <72.34%> (+60.71%) |
:arrow_up: |
core/context.go | 20.2% <0%> (+8.33%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 82f9de7...1f84df8. Read the comment docs.
@kobolog would you mind taking a look?
Looks good!
Thanks for the good work!
Remove the pulse info from the
stash
when a backend is removed. This is to avoid the scenario where an unhealthy backend stored in thestash
remains unhealthy after being scaled down and up again. In this case the pulse update had no effect as the removed backend was still found in thestash
.Fix made in 2 commits to better visualise the actual change in behaviour