kobolog / gorb

IPVS on steroids – REST API, heartbeats, service discovery and more
GNU Lesser General Public License v3.0
809 stars 83 forks source link

Allow generic ipvs scheduler flags #49

Closed jsravn closed 6 years ago

jsravn commented 6 years ago

ipvs/ipvsadm support the generic flags 'flag-1', 'flag-2', and 'flag-3' for custom schedulers. Currently gorb rejects those flags as invalid. This patch changes gorb to allow those flags.

kobolog commented 6 years ago

It would be nice if all the tests still pass with this PR =) Then I'll merge it.

jsravn commented 6 years ago

@kobolog It looks like a bug w/ the travis build?

[INFO]  Replacing existing vendor dependencies
[INFO]  Removing nested vendor and Godeps/_workspace directories...
[INFO]  Removing: /home/travis/gopath/src/github.com/kobolog/gorb/vendor/github.com/coreos/etcd/cmd/vendor
[ERROR] Unable to strip vendor directories: open /home/travis/gopath/src/github.com/kobolog/gorb/vendor/github.com/coreos/etcd/cmd/vendor: no such file or directory
An Error has occurred
jsravn commented 6 years ago

Rebased on master to fix conflicts - hopefully it will fix the build as well.

codecov-io commented 6 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   39.42%   39.42%           
=======================================
  Files          18       18           
  Lines         804      804           
=======================================
  Hits          317      317           
  Misses        457      457           
  Partials       30       30
Impacted Files Coverage Δ
core/context.go 18.83% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82598db...03b3abf. Read the comment docs.

jsravn commented 6 years ago

@kobolog Good to go!

kobolog commented 6 years ago

👍