kobolog / gorb

IPVS on steroids – REST API, heartbeats, service discovery and more
GNU Lesser General Public License v3.0
809 stars 83 forks source link

Fix vendored dependencies #51

Closed jsravn closed 6 years ago

jsravn commented 6 years ago

Remove 'vendor' from gitignore, and add stretchr dep that was previously added. Also remove glide install -v to catch broken vendor folder.

vendor got added to gitignore in a previous commit but the vendor folder was not removed, which was pretty confusing when trying to do dev. We could either remove vendor completely, or restore the prior behaviour which is what I've done here.

codecov-io commented 6 years ago

Codecov Report

Merging #51 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   39.42%   39.42%           
=======================================
  Files          18       18           
  Lines         804      804           
=======================================
  Hits          317      317           
  Misses        457      457           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82598db...79b77eb. Read the comment docs.

kobolog commented 6 years ago

I think removing vendor and relying on glide install is better from the perspective of repo pollution. Dependencies are still going to have their revisions fixed in glide.lock but the repo won't be cluttered with all these unrelated files. What do you think?

jsravn commented 6 years ago

Removing vendor makes dev slightly more painful - need to remember to glide install on git pull. So I usually prefer having vendor. But I don't feel that strongly about it. It's more important we either fix vendor or remove it completely. If you'd like I can remove it.

kobolog commented 6 years ago

I think glide install is cleaner and I generally don't like clutter in the repo =)

jsravn commented 6 years ago

@kobolog Okay, I made https://github.com/kobolog/gorb/pull/53 for it.