Closed jsravn closed 6 years ago
Merging #51 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 39.42% 39.42%
=======================================
Files 18 18
Lines 804 804
=======================================
Hits 317 317
Misses 457 457
Partials 30 30
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 82598db...79b77eb. Read the comment docs.
I think removing vendor
and relying on glide install
is better from the perspective of repo pollution. Dependencies are still going to have their revisions fixed in glide.lock
but the repo won't be cluttered with all these unrelated files. What do you think?
Removing vendor makes dev slightly more painful - need to remember to glide install on git pull. So I usually prefer having vendor. But I don't feel that strongly about it. It's more important we either fix vendor or remove it completely. If you'd like I can remove it.
I think glide install
is cleaner and I generally don't like clutter in the repo =)
@kobolog Okay, I made https://github.com/kobolog/gorb/pull/53 for it.
Remove 'vendor' from gitignore, and add stretchr dep that was previously added. Also remove
glide install -v
to catch broken vendor folder.vendor
got added to gitignore in a previous commit but the vendor folder was not removed, which was pretty confusing when trying to do dev. We could either remove vendor completely, or restore the prior behaviour which is what I've done here.