Row-based repeating group calculation not working correctly

[MartijnR]

see Paul's email on 8/24.

Looks like position(..) is not working correctly perhaps

[MartijnR]

• [x] check enketo-core : bug does not seem to exist with cleaned-up form: http://localhost:8005/?xform=position-bug-repeat.xml
• [x] check enketo-express: cannot reproduce with http://localhost:8005/preview?form=https://gist.githubusercontent.com/MartijnR/f92b6da8e5b48e6457f00564477e2216/raw/711e97c56523c11cef4ae27c2d6d1c0bb164265b/repeat-position-bug.xml
• [x] check enketo-express-oc: yes! (see previous link)
• [x] check after disabling xpath-extensions: no, not the cause
• [x] check after merging from kobotoolbox: no
• [x] check which Form.js or FormModel.js customizations could cause this
• [x] check readonly.js customizations
• [x] check disabling dn widget

[MartijnR]

The values are correctly stored in the model (as 1 Standing, 2 Sitting, 3 Lying) but shown incorrectly to user (as 3 Lying, 3 Lying, 3 Lying).

A very interesting bug!

[MartijnR]

• [x] go through all remaining customizations (disable them one-by-one)

The issue is in the relevant.js module enable override. This function bypasses the isRelevant check. Don't remember why.

• [x] figure out why isRelevant check had to be disabled.
• [x] figure out why the view is incorrect (and the model correct)

[MartijnR]

Looks like the bug is in calculate.js in Enketo Core when the update function is called with a relevantPath only, and that relevantPath is a repeat.

• [x] create a test in Enketo Core
• [x] fix in Enketo Core
• [x] propagate fix all the way to ee-oc

[MartijnR]

There is actually a way to show this bug in Enketo Core without engine modifications.