search

kobotoolbox / enketo-express

We've moved! Please use the new repository 🠊 https://github.com/enketo/enketo-express
Apache License 2.0
102 stars 90 forks source link

DN: bug in closed-modified in repeats #739

Closed MartijnR closed 7 years ago

MartijnR commented 7 years ago

Steps:

  1. Add a second row to a repeating group
  2. In the second row, add a new query
  3. Close the query
  4. Open the Query widget to view the history.

Expected: No autoquery was added. Query status is Closed (verifiable in OC).

Actual: An autoquery for "Data changed after query was closed" was added immediately after the query was closed. Query status is Closed-Modified (verifiable in OC).

MartijnR commented 7 years ago

Cannot reproduce with discrepancy-notes-repeat.xlsx Cannot reproduce with vital signs form (sent by email on 5/9) either.

MartijnR commented 7 years ago

Another one: Steps:

  1. Open form with constraint on repeating group field that is based on another field in the repeating group (for example, field1 > field2)
  2. In the first row, add a query to field1
  3. Close the query
  4. In the second row, enter a value for field2

Expected: No changes to the fields in the first repeat entry based on updates to the second entry.

Actual: An autoquery for "Data changed after query was closed" is added to field1 in repeat entry one.

MartijnR commented 7 years ago

updated.fullPath includes positions /path/to/rep[3]/node, so the check to avoid unwanted autoqueries fails