Print button in edit or view mode

kobotoolbox / enketo-express

We've moved! Please use the new repository 🠊 https://github.com/enketo/enketo-express

Apache License 2.0

102 stars 90 forks source link

Print button in edit or view mode #992

Closed MartijnR closed 6 years ago

MartijnR commented 6 years ago

We are experiencing another issue with the Enketo print-form link. It works as expected in the initial data entry session, when there is no data in the form and when data is entered. The print-form link does not work when reopening the form in edit or view mode after the initial data entry session. It seems as if the link is disabled.

[ ] check whether in regular EE as well or only in OC (fs)

MartijnR commented 6 years ago

Looks like the workaround for #990 also works around this issue.

Will leave open as this workaround is temporary.

pbowen-oc commented 6 years ago

@MartijnR - We're still observing this issue. Note that the issue from #990 appears to be mostly fixed.

MartijnR commented 6 years ago

Issue is with printify dn logic. Click after open DN widget works.

MartijnR commented 6 years ago

cannot reproduce with

curl --user enketorules: -d "server_url=https://enketo-aggregate.appspot.com&form_id=vitals&instance=<demo-vitals-grid-v9/>&instance_id=b" http://localhost:8005/oc/api/v1/instance/edit

This may have something to do with the values of empty discrepancy notes questions that are in the record to be edited.

@pbowen-oc, could you please paste the screenshot of the console error we saw when clicking the Print button?

pbowen-oc commented 6 years ago

@MartijnR -

MartijnR commented 6 years ago

Can be reproduced with a record that includes at least one query with a user property.

MartijnR commented 6 years ago

@pbowen-oc, version 1.65.0.oc-1 has the two urgent fixes and is ready for testing.