edit fs view, the loader image moves to the top of the screen

kobotoolbox / enketo-express

We've moved! Please use the new repository 🠊 https://github.com/enketo/enketo-express

Apache License 2.0

102 stars 90 forks source link

edit fs view, the loader image moves to the top of the screen #999

Closed MartijnR closed 6 years ago

MartijnR commented 6 years ago

possibly related to iframe (and size of iframe)

MartijnR commented 6 years ago

Cannot reproduce, even when throttling CPU 6x and the Kitchen Sink form.

[x] try view-only
[x] try note-only

MartijnR commented 6 years ago

In order to reproduce this:

~~check with @pbowen-oc if an empty form has the same behavior~~ YES
~~if so, get an OC url to reproduce with (likely to do with iframe CSS)~~ not iframe-related
~~if not, does it happen in edit mode for small/empty records? (If not, it is likely related to loading large records).~~

MartijnR commented 6 years ago

https://form.dev.openclinica.io/single/fs/c/i/::d7417e80eecfa318f0ab70a779363946?ecid=76dc8953cf1b9d6b802c2f2837534f66286d99620f26903a3cfbb679d52d8de1

MartijnR commented 6 years ago

Very interesting. When looking at the actual Enketo webform url, i.e. the src of the iframe in the window served by OC, I see a whole bunch of stuff that is added to the HTML outside of Enketo.

This is causing the odd behavior. It's also briefly showing a different loading image at some point:

Some of the things that are loaded are fairly heavy too (jQuery, which is already part of the Enketo bundle, Angular, etc.).

If these scripts and styles are not injected deliberately, it would be good to remove them (It may just be one scripts that triggers loading of all the others).

pbowen-oc commented 6 years ago

@MartijnR - The other loading image you pointed out is from a separate integration we are testing. I'm not sure about the rest of the scripts and styles you noticed.

MartijnR commented 6 years ago

Thanks. It may just be one script that dynamically loads all the other scripts and stylesheets.