search

kobotoolbox / kobo-helm-chart

This project is new. We do not yet release stable versions.
GNU Affero General Public License v3.0
4 stars 9 forks source link

Add envFrom with secret and configmap for pre-install jobs #68

Closed wozniakpl closed 5 months ago

wozniakpl commented 5 months ago

On a deployment, I set KPI_DEFAULT_FILE_STORAGE to a value ending with AzureStorage. After setting this, pre-install jobs fail in such way:

django.core.exceptions.ImproperlyConfigured: Set the AZURE_ACCOUNT_KEY environment variable

Looks like the jobs don't have the env available from the configmap and secret, where the AZURE- envs are. This PR should fix that.

bufke commented 5 months ago

This wouldn't be effective as the pre-install job runs before the config maps get updated. We'd prefer to set config maps first and then the update job. But as far as I know, we cannot. A workaround is to disable the install/update migrate job (in values) and run the migration manually.

Related kpi settings IMO it would be better to not error out here but I would need to discuss with our team.

wozniakpl commented 5 months ago

Thank you for your response. I understand now that this fix would not be applicable in that case. I'll manage to implement a workaround on my end.