Remove settings provided by KPI from "Project Settings" iframe

kobotoolbox / kobocat

Our (backend) server for providing blank forms to Collect and Enketo and for receiving and storing submissions.

BSD 2-Clause "Simplified" License

117 stars 127 forks source link

Remove settings provided by KPI from "Project Settings" iframe #488

Open jnm opened 6 years ago

jnm commented 6 years ago

screenshot_20181017-111111 screenshot_20181017-111115

[ ] Remove entire right column
[ ] Move "Accept Submissions" to non-iframe KPI settings; yes-to-no change should archive asset, no-to-yes should unarchive
- This needs some UI creativity. The ideal solution would instruct people that "archiving" is the new way to disallow submissions and still be easy for those familiar with the "Accept Submissions" terminology to find
[ ] Keep "Existing Form Files" / "Add Document"
[ ] Move delete button to non-iframe KPI settings (should trigger normal KPI asset deletion, including the warning modal)
[ ] Remove anything that would allow adding new "Rest Services", but...
[ ] Keep the list of existing "Rest Services" and the ability to delete each of them

This is in kobotoolbox/kobocat-template. More details to follow...

jnm commented 6 years ago

@leszek, these changes should only apply to the iframe displayed in KPI, not the settings shown in KC ("Projects (legacy)"). It's fine to hide them with CSS only. I'm sorry that my screenshots show KC settings, but that was the easiest way for me to get (almost) all the options on one screen on mobile 😊 Check out https://github.com/kobotoolbox/kobocat-template/pull/84 for some insight into iframe-specific styling.

@tinok, any comments on the changes mentioned in the issue description?

tinok commented 6 years ago

@jnm @magicznyleszek This sounds correct. I mocked up what it should look like and which elements should go where:

jnm commented 5 years ago

@tinok, your mockup indicates that "DELETE PROJECT AND DATA" should be added to KPI's Settings->General, correct? If so, we will have it display the confirmation modal that KPI already displays when a user attempts to delete from the form list. Edit: this is already implemented in https://github.com/kobotoolbox/kpi/pull/2034

magicznyleszek commented 5 years ago

@tinok in an already done PR the "DELETE" button is part of KPI and doesn't have "…PROJECT AND DATA" text: https://github.com/kobotoolbox/kpi/pull/2034 (see screenshot)