Open magicznyleszek opened 6 years ago
@magicznyleszek is this still an issue with the new spinner?
I was wrong and this is still an issue. The things I found out during debugging:
280px
, with older version of webfonts-generator
we had to keep it over 1000px
as glyphs were corrupted during conversion), but I tried resizing all icons and it didn't change anythingspinner.svg
was 1000x1000px
and other icons stay 280x280px
), but this is not acceptable as all the other icons are renderer off center and smaller (proportionally).If you add some styles to generated icons, it is clear that SVG design that is perfectly in center is rendered a bit lower than it should:
The solution would be one of:
webfonts-generator
the issue will be gonek-icons
flow and make it a completely separate thingI lean towards 1. as it should and will happen eventually, and with 2. we need to update all the places that use spinner icon currently.
There is also a bit separate idea to not use the regular spinning spinner, but use another loading animation inspired by our new logo, e.g.:
Description
The spinner spins around a point that is a tiny bit off-center:![kapture 2018-08-19 at 9 37 00](https://user-images.githubusercontent.com/2521888/44306647-9deee800-a393-11e8-90e2-41dd5493d262.gif)
We could design a square one, that doesn't rely on rotating.
Sidenote: performance-wise CSS spinners are ok: https://github.com/h5bp/lazyweb-requests/issues/103