search

kobus-v-schoor / dotgit

A comprehensive solution to managing your dotfiles
GNU General Public License v2.0
167 stars 12 forks source link

Add hostname to category list for groups #30

Closed drbayer closed 3 years ago

drbayer commented 3 years ago

The group that gets applied must match the hostname, but if there are host-specific files they are currently ignored.

Take the following filelist:

laptop=vim,shell

.vimrc:vim
.bash_profile:shell
.gitconfig:laptop

On the computer with hostname laptop, the files .vimrc and .bash_profile would be handled as intended, but .gitconfig would be ignored unless you modify the group line to look like this:

laptop=vim,shell,laptop

In order to allow for different versions of files on different hosts, when the group name matches the current hostname add that to the list of categories for the group.

drbayer commented 3 years ago

I'm not sure why the tests are failing to upload to coveralls. First run said it was missing github token and to add the github token to env for that step. I tried a few iterations of that, but no luck making that work yet. I haven't worked with github actions or coveralls before, so not sure what I'm missing.

kobus-v-schoor commented 3 years ago

Hi @drbayer, thanks for the pull request, I didn't want to merge into master directly due to the extra commits so I cherry picked your first commit into master and everything seems to be in order. I'll make a new release to publish the fix, thanks

kobus-v-schoor commented 3 years ago

I also pushed a fix for the coverage issue for future pull requests :+1:

drbayer commented 3 years ago

Thanks! The first commit was the only meaningful one :-)