search

koca2000 / NoteBlockAPI

https://www.spigotmc.org/resources/noteblockapi.19287/
GNU Lesser General Public License v3.0
119 stars 40 forks source link

Fix volume being ignored in NoteblockSongPlayer #81

Closed LaserSlime closed 2 years ago

LaserSlime commented 2 years ago

I don't know why it plays the note twice in the first place, but unlike ChannelMode#play(), Player#playNote() completely ignores the volume so it should be removed. If this was intentional there should at least be a way to toggle it off.

koca2000 commented 2 years ago

For some unknown reason the original author of NoteBlockAPI done it this way and since there wasn't any documentation I left it as it is. I took a look to the Spigot source code and there is no important difference between the playSound and playNote so I think playNote may be removed as you did. Please remove also key variable calculation since it is unused now.