WriteSingleCoilRequest.setCoil(true) always fails

kochedykov / jlibmodbus

JLibModbus - is an implementation of the Modbus protocol v1.1b in java language. Java modbus library. It works. Welcome.

http://kochedykov.github.io/jlibmodbus/

Apache License 2.0

299 stars 128 forks source link

Closed wielantu closed 3 years ago

wielantu commented 3 years ago

It is not possible to send a WriteSingleCoilRequest with value true/ON.

The fix for #33 added a short cast to the value parameter in Modbus.java:

    static public boolean checkRegisterValue(int value) {
        return checkRange((short)value, 0, Modbus.MAX_REGISTER_VALUE);
    }

   Modbus.checkRegisterValue(COIL_VALUE_ON);

always returns false.

This means

WriteSingleCoilRequest.setCoil(true)

always fails.

wielantu commented 3 years ago

This is a duplicate of #52