search

kochedykov / jlibmodbus

JLibModbus - is an implementation of the Modbus protocol v1.1b in java language. Java modbus library. It works. Welcome.
http://kochedykov.github.io/jlibmodbus/
Apache License 2.0
307 stars 128 forks source link

CheckRegister value does truncate negative values #68

Closed r3mv closed 12 months ago

r3mv commented 3 years ago

Method checkRegisterValue can be called with a negative integer value that would still be valid to be stored in a Short. However checkRange checks the value is btw 0 to MAX_REGISTER value in my opinion it should be btw Short.MIN_VALUE and Short.MAX_VALUE